[ISSUE #9164] Add producer stats manager #9165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I think it is enough to monitor the time taken to call the sending API directly in the application. There is no need to integrate it into the sending client. |
HScarb
force-pushed
the
feat/produce-stats
branch
3 times, most recently
from
79fe376 to
9539b04
Compare
HScarb
force-pushed
the
feat/produce-stats
branch
from
9539b04 to
2e70aaf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9165 +/- ##
=============================================
- Coverage 48.04% 48.01% -0.03%
- Complexity 12064 12084 +20
=============================================
Files 1320 1322 +2
Lines 92824 93080 +256
Branches 11897 11931 +34
=============================================
+ Hits 44596 44693 +97
- Misses 42734 42849 +115
- Partials 5494 5538 +44 ☔ View full report in Codecov by Sentry. |
RongtongJin
changed the title
RongtongJin
changed the title
humkum
reviewed
Feb 12, 2025
| private final StatsItemSet topicSendFailedTPS; | ||
| private final StatsItemSet topicSendRT; | ||
|
|
||
| public ProducerStatsManager(final ScheduledExecutorService scheduledExecutorService) { |
There was a problem hiding this comment.
Maybe you should add some unit tests for this feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9164
Brief Description
Add a producer stats manager to the 4.x Java client to periodically print produce stats in the client logs.
How Did You Test This Change?
Running 4.x java client's producer benchmark and checking for the logs.