Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Seatunnel-web] Error when conditional column is not used in SE… #238

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

BilwaST
Copy link
Contributor

@BilwaST BilwaST commented Nov 6, 2024

…LECT clause

Purpose of this pull request

Check list

@bilst-visa
Copy link

Test Report:

job profile content with my changes:

image

Copy link
Collaborator

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@arshadmohammad arshadmohammad merged commit d862b61 into apache:main Nov 6, 2024
15 checks passed
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the better place to do this thing is in


The place fine tuning source config of jdbc.

@BilwaST
Copy link
Contributor Author

BilwaST commented Nov 6, 2024

Hi @Hisoka-X

I did not add it here as not all DataSourceConfigSwitcher extends this BaseJdbcDataSourceConfigSwitcher class. For example HiveDataSourceConfigSwitcher.

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 6, 2024

Hi @Hisoka-X

I did not add it here as not all DataSourceConfigSwitcher extends this BaseJdbcDataSourceConfigSwitcher class. For example HiveDataSourceConfigSwitcher.

But the where_condition only worked on jdbc connector, so change it in BaseJdbcDataSourceConfigSwitcher is more reasonable.

@arshadmohammad
Copy link
Collaborator

arshadmohammad commented Nov 6, 2024

Thanks @Hisoka-X for suggesting the change.
yes, it makes better sense to put the changes in BaseJdbcDataSourceConfigSwitcher.
@BilwaST can you raise another addendum PR

@BilwaST
Copy link
Contributor Author

BilwaST commented Nov 6, 2024

Thank you @Hisoka-X @arshadmohammad for the feedback. I have raised another PR #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants