Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][zeta][Connector-paimon] Fix paimon run from checkpoint bug #8730

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

uniding
Copy link
Contributor

@uniding uniding commented Feb 14, 2025

Purpose of this pull request

fix bugs:
#8460
#8070

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@uniding uniding changed the title [Fix][zeta][Connector-paimon] Fix paimon run from checkpoint error #8460 #8070 [Fix][zeta][Connector-paimon] Fix paimon run from checkpoint bug Feb 14, 2025
@Hisoka-X
Copy link
Member

Please follow the link to open github action on your fork repositoy. https://github.com/apache/seatunnel/pull/8730/checks?check_run_id=37219576667

@uniding
Copy link
Contributor Author

uniding commented Feb 17, 2025

Please follow the link to open github action on your fork repositoy. https://github.com/apache/seatunnel/pull/8730/checks?check_run_id=37219576667

I have checked and passed

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PaimonSaveModeHandler too. I think we can skip setLoadTable in PaimonSaveModeHandler if paimonTable field value is not null.

@Hisoka-X
Copy link
Member

Could you add a test case too?

@uniding
Copy link
Contributor Author

uniding commented Feb 19, 2025

Please update PaimonSaveModeHandler too. I think we can skip setLoadTable in PaimonSaveModeHandler if paimonTable field value is not null.

It has been modified. If it is RECREATE_SCHEMA mode, it needs to be set

@Hisoka-X
Copy link
Member

Could you add a test case too?

@uniding

@uniding
Copy link
Contributor Author

uniding commented Feb 19, 2025

Could you add a test case too?

@uniding

This modification will no longer report null pointer errors when running from checkpoint, but the Paimon jar package code will report error " File deletion conflicts detected! Give up committing.
err.txt

so test cases cannot be added. It is estimated that a new version of Paimon jar will solve this problem
@Hisoka-X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants