[improve] update localfile connector config #8765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liunaijie
reviewed
Feb 21, 2025
| @@ -37,7 +36,7 @@ public HadoopConf getHadoopConfig() { | |||
|
|
|||
| @Override | |||
| public String getPluginName() { | |||
| return FileSystemType.LOCAL.getFileSystemPluginName(); | |||
| return "LocalFile"; | |||
There was a problem hiding this comment.
This change is not necessary.
| @@ -35,7 +33,7 @@ | |||
| import static org.apache.seatunnel.api.sink.DataSaveMode.DROP_DATA; | |||
| import static org.apache.seatunnel.api.sink.DataSaveMode.ERROR_WHEN_DATA_EXISTS; | |||
|
|
|||
| public class BaseSinkConfig { | |||
| public class BaseSinkConfig extends FileBaseOptions { | |||
There was a problem hiding this comment.
Suggest we have an unified class name style.
How about rename to
FileBaseSinkOptionsFileBaseSourceOptionsFileBaseOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
subtask of #8576
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.