feat(rust/sedona-functions): Implement native ST_ZMFlag using WKBHeader #260
+246
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #171 (comment), for why the difference isn't as large anymore. |
paleolimbot
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Thank you!
To really make these go fast I think we would need something like #201 (i.e., allocate a Vec<WkbHeader>s and fill them in using a series of loops that do not contain match, if, or ?). Another potential improvement would be eliminate (most) buffer bounds checking by doing it once based on the top-level geometry type (works for everything except geometrycollection).
(Also...these are really fast already!)
paleolimbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #198.
Quite literally copied
st_haszmimplementation (including tests) and modified everything to be the int outputs instead of the boolean outputs.