This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
Could org.apache.servicecomb.pack:persistence-jpa:0.7.0-SNAPSHOT drop off redundant dependencies to loose weight? #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemJiang
reviewed
Sep 7, 2021
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot</artifactId> | ||
| <version>2.1.6.RELEASE</version> |
There was a problem hiding this comment.
Please use the dependency manager in pom instead of specify the version directly here.
It will help us manage the third party dependencies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coolbeevip Hi, I am a user of project org.apache.servicecomb.pack:persistence-jpa:0.7.0-SNAPSHOT. I found that its pom file introduced 37 dependencies. However, among them, 7 libraries (18%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for this project.
This PR helps org.apache.servicecomb.pack:persistence-jpa:0.7.0-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.
Best regards