Remove useless PrimaryKeyIngestPosition.convert() (#33353)

apache · Oct 22, 2024 · 1a494de · 1a494de
1 parent 1c76b9b
commit 1a494de
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 22 deletions.
diff --git a/...e/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java b/...e/shardingsphere/data/pipeline/core/ingest/position/type/pk/PrimaryKeyIngestPosition.java
@@ -40,13 +40,6 @@ public interface PrimaryKeyIngestPosition<T> extends IngestPosition {
      */
     T getEndValue();
 
-    /**
-     * Convert value.
-     * @param value value to be converted
-     * @return converted value
-     */
-    T convert(String value);
-
     /**
      * Get type.
      *

diff --git a/...here/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java b/...here/data/pipeline/core/ingest/position/type/pk/type/IntegerPrimaryKeyIngestPosition.java
@@ -43,11 +43,6 @@ public Long getEndValue() {
         return endValue;
     }
 
-    @Override
-    public Long convert(final String value) {
-        return Long.parseLong(value);
-    }
-
     @Override
     public char getType() {
         return 'i';

diff --git a/...phere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java b/...phere/data/pipeline/core/ingest/position/type/pk/type/StringPrimaryKeyIngestPosition.java
@@ -36,11 +36,6 @@ public StringPrimaryKeyIngestPosition(final String beginValue, final String endV
         this.endValue = Strings.emptyToNull(endValue);
     }
 
-    @Override
-    public String convert(final String value) {
-        return value;
-    }
-
     @Override
     public char getType() {
         return 's';

diff --git a/...gsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java b/...gsphere/data/pipeline/core/ingest/position/type/pk/type/UnsupportedKeyIngestPosition.java
@@ -34,11 +34,6 @@ public Void getEndValue() {
         return null;
     }
 
-    @Override
-    public Void convert(final String value) {
-        throw new UnsupportedOperationException("");
-    }
-
     @Override
     public char getType() {
         return 'u';