Remove disable from FilePluginE2EIT (#31693)

* Remove disable from FilePluginE2EIT * Update file-advisors.yaml
apache · Jun 14, 2024 · 3369dcc · 3369dcc
1 parent 5adfc14
commit 3369dcc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml b/agent/plugins/logging/type/file/src/main/resources/META-INF/conf/file-advisors.yaml
@@ -22,5 +22,9 @@ advisors:
       - name: create
         type: method
         params:
-          - index: 3
-            type: java.util.Map
+          - index: 0
+            type: org.apache.shardingsphere.metadata.persist.MetaDataPersistService
+          - index: 1
+            type: org.apache.shardingsphere.mode.manager.ContextManagerBuilderParameter
+          - index: 2
+            type: org.apache.shardingsphere.infra.instance.ComputeNodeInstanceContext
diff --git a/...ing/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java b/...ing/file/src/test/java/org/apache/shardingsphere/test/e2e/agent/file/FilePluginE2EIT.java
@@ -22,7 +22,6 @@
 import org.apache.shardingsphere.test.e2e.agent.file.asserts.ContentAssert;
 import org.apache.shardingsphere.test.e2e.agent.file.cases.IntegrationTestCasesLoader;
 import org.apache.shardingsphere.test.e2e.agent.file.cases.LogTestCase;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.condition.EnabledIf;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.ExtensionContext;
@@ -35,7 +34,6 @@
 
 import static org.junit.jupiter.api.Assertions.assertFalse;
 
-@Disabled("Fix me by @jiangmaolin")
 @ExtendWith(AgentTestActionExtension.class)
 class FilePluginE2EIT {