Refactor ShardingParameterRewritersRegistryTest and EncryptParameterR…

…ewritersRegistryTest (#33618)
apache · Nov 11, 2024 · a6bc09b · a6bc09b
1 parent 96443c5
commit a6bc09b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 13 deletions.
diff --git a/...pache/shardingsphere/encrypt/rewrite/parameter/EncryptParameterRewritersRegistryTest.java b/...pache/shardingsphere/encrypt/rewrite/parameter/EncryptParameterRewritersRegistryTest.java
@@ -23,7 +23,6 @@
 import org.apache.shardingsphere.encrypt.rewrite.parameter.rewriter.EncryptInsertValueParameterRewriter;
 import org.apache.shardingsphere.encrypt.rewrite.parameter.rewriter.EncryptPredicateParameterRewriter;
 import org.apache.shardingsphere.encrypt.rule.EncryptRule;
-import org.apache.shardingsphere.infra.binder.context.statement.dml.SelectStatementContext;
 import org.apache.shardingsphere.infra.database.core.DefaultDatabase;
 import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
 import org.junit.jupiter.api.Test;
@@ -35,19 +34,13 @@
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 class EncryptParameterRewritersRegistryTest {
 
     @Test
     void assertGetParameterRewriters() {
-        EncryptRule rule = mock(EncryptRule.class, RETURNS_DEEP_STUBS);
-        when(rule.findEncryptTable("foo_tbl").isPresent()).thenReturn(true);
-        SelectStatementContext sqlStatementContext = mock(SelectStatementContext.class, RETURNS_DEEP_STUBS);
-        when(sqlStatementContext.getTablesContext().getTableNames()).thenReturn(Collections.singleton("foo_tbl"));
-        List<ParameterRewriter> actual = new ArrayList<>(new EncryptParameterRewritersRegistry(rule, DefaultDatabase.LOGIC_NAME, Collections.emptyList()).getParameterRewriters());
+        List<ParameterRewriter> actual = new ArrayList<>(new EncryptParameterRewritersRegistry(mock(EncryptRule.class), DefaultDatabase.LOGIC_NAME, Collections.emptyList()).getParameterRewriters());
         assertThat(actual.size(), is(5));
         assertThat(actual.get(0), instanceOf(EncryptAssignmentParameterRewriter.class));
         assertThat(actual.get(1), instanceOf(EncryptPredicateParameterRewriter.class));

diff --git a/...che/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewritersRegistryTest.java b/...che/shardingsphere/sharding/rewrite/parameter/ShardingParameterRewritersRegistryTest.java
@@ -17,7 +17,6 @@
 
 package org.apache.shardingsphere.sharding.rewrite.parameter;
 
-import org.apache.shardingsphere.infra.binder.context.statement.dml.SelectStatementContext;
 import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.ParameterRewriter;
 import org.apache.shardingsphere.infra.rewrite.parameter.rewriter.keygen.GeneratedKeyInsertValueParameterRewriter;
 import org.apache.shardingsphere.infra.route.context.RouteContext;
@@ -30,16 +29,12 @@
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 class ShardingParameterRewritersRegistryTest {
 
     @Test
     void assertGetParameterRewriters() {
-        SelectStatementContext statementContext = mock(SelectStatementContext.class, RETURNS_DEEP_STUBS);
-        when(statementContext.getPaginationContext().isHasPagination()).thenReturn(true);
         List<ParameterRewriter> actual = new ArrayList<>(new ShardingParameterRewritersRegistry(mock(RouteContext.class)).getParameterRewriters());
         assertThat(actual.size(), is(2));
         assertThat(actual.get(0), instanceOf(GeneratedKeyInsertValueParameterRewriter.class));