Refactor TransmissionJobManager (#29265)

apache · Dec 2, 2023 · bdfd897 · bdfd897
1 parent ffeb87f
commit bdfd897
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/...java/org/apache/shardingsphere/data/pipeline/core/job/service/TransmissionJobManager.java b/...java/org/apache/shardingsphere/data/pipeline/core/job/service/TransmissionJobManager.java
@@ -65,17 +65,22 @@ public Collection<TransmissionJobItemInfo> getJobItemInfos(final String jobId) {
                 result.add(new TransmissionJobItemInfo(shardingItem, jobInfo.getTableName(), null, startTimeMillis, 0, errorMessage));
                 continue;
             }
-            int inventoryFinishedPercentage = 0;
-            if (JobStatus.EXECUTE_INCREMENTAL_TASK == jobItemProgress.getStatus() || JobStatus.FINISHED == jobItemProgress.getStatus()) {
-                inventoryFinishedPercentage = 100;
-            } else if (0 != jobItemProgress.getProcessedRecordsCount() && 0 != jobItemProgress.getInventoryRecordsCount()) {
-                inventoryFinishedPercentage = (int) Math.min(100, jobItemProgress.getProcessedRecordsCount() * 100 / jobItemProgress.getInventoryRecordsCount());
-            }
+            int inventoryFinishedPercentage = getInventoryFinishedPercentage(jobItemProgress);
             result.add(new TransmissionJobItemInfo(shardingItem, jobInfo.getTableName(), jobItemProgress, startTimeMillis, inventoryFinishedPercentage, errorMessage));
         }
         return result;
     }
 
+    private static int getInventoryFinishedPercentage(final TransmissionJobItemProgress jobItemProgress) {
+        if (JobStatus.EXECUTE_INCREMENTAL_TASK == jobItemProgress.getStatus() || JobStatus.FINISHED == jobItemProgress.getStatus()) {
+            return 100;
+        }
+        if (0 != jobItemProgress.getProcessedRecordsCount() && 0 != jobItemProgress.getInventoryRecordsCount()) {
+            return (int) Math.min(100, jobItemProgress.getProcessedRecordsCount() * 100 / jobItemProgress.getInventoryRecordsCount());
+        }
+        return 0;
+    }
+
     /**
      * Get job progress.
      *