Remove useless ShardingSphereTable.putColumn (#33787)

apache · Nov 24, 2024 · fb882f2 · fb882f2
1 parent 65011f9
commit fb882f2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/.../org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java b/.../org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereSchema.java
@@ -209,7 +209,7 @@ public List<String> getVisibleColumnNames(final String tableName) {
      * @return visible column names and indexes
      */
     public Map<String, Integer> getVisibleColumnNamesAndIndexes(final String tableName) {
-        return containsTable(tableName) ? getTable(tableName).getVisibleColumnsAndIndexes() : Collections.emptyMap();
+        return containsTable(tableName) ? getTable(tableName).getVisibleColumnsAndIndexMap() : Collections.emptyMap();
     }
 
     /**

diff --git a/...a/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java b/...a/org/apache/shardingsphere/infra/metadata/database/schema/model/ShardingSphereTable.java
@@ -52,7 +52,7 @@ public final class ShardingSphereTable {
 
     private final List<String> visibleColumns = new ArrayList<>();
 
-    private final Map<String, Integer> visibleColumnsAndIndexes = new CaseInsensitiveMap<>();
+    private final Map<String, Integer> visibleColumnsAndIndexMap = new CaseInsensitiveMap<>();
 
     private final List<String> primaryKeyColumns = new ArrayList<>();
 
@@ -64,11 +64,7 @@ public ShardingSphereTable() {
 
     public ShardingSphereTable(final String name, final Collection<ShardingSphereColumn> columns,
                                final Collection<ShardingSphereIndex> indexes, final Collection<ShardingSphereConstraint> constraints) {
-        this.name = name;
-        this.columns = createColumns(columns);
-        this.indexes = createIndexes(indexes);
-        this.constraints = createConstraints(constraints);
-        type = TableType.TABLE;
+        this(name, columns, indexes, constraints, TableType.TABLE);
     }
 
     public ShardingSphereTable(final String name, final Collection<ShardingSphereColumn> columns,
@@ -91,7 +87,7 @@ private Map<ShardingSphereMetaDataIdentifier, ShardingSphereColumn> createColumn
             }
             if (each.isVisible()) {
                 visibleColumns.add(each.getName());
-                visibleColumnsAndIndexes.put(each.getName(), index++);
+                visibleColumnsAndIndexMap.put(each.getName(), index++);
             }
         }
         return result;
@@ -113,15 +109,6 @@ private Map<String, ShardingSphereConstraint> createConstraints(final Collection
         return result;
     }
 
-    /**
-     * Put column meta data.
-     *
-     * @param column column meta data
-     */
-    public void putColumn(final ShardingSphereColumn column) {
-        columns.put(new ShardingSphereMetaDataIdentifier(column.getName()), column);
-    }
-
     /**
      * Get column meta data via column name.
      *