Feat: Support parsing Oracle CREATE MATERIALIZED sql #27994
Conversation
...re/sql/parser/sql/dialect/statement/oracle/ddl/OracleCreateMaterializedViewLogStatement.java
Outdated
Show resolved
Hide resolved
...phere/sql/parser/sql/dialect/statement/oracle/ddl/OracleCreateMaterializedViewStatement.java
Outdated
Show resolved
Hide resolved
|
@strongduanmu I've merged the master to fix the failing CI tests. Could you please review this again? Thanks! |
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
Outdated
Show resolved
Hide resolved
| AS selectSubquery | ||
| ; | ||
|
|
||
| rowLimitingClause |
There was a problem hiding this comment.
Hi @zhangfengcdt , can you take a look at DMLStatement? I think rowLimitingClause and selectSubquery already exist in DMLStatement.
There was a problem hiding this comment.
@strongduanmu I was trying to import the "DMLStatement" in the DDL g4 statement, however, this causes a circular import since DML also imports DDL g4 file.
I think the circular dependency could be removed by moving some of the definitions into the base g4 file, but that seems to be out of scope for this change.
Could you advise how to proceed? Thanks!
There was a problem hiding this comment.
Which DDL statements will DML statements depend on? This seems unreasonable.
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
|
Hi @zhangfengcdt, does this pr has any update? |
@strongduanmu I have removed the duplicated parsing rules in the DDLStatement.g4 as you suggested and use dependency on DMLStatement.g4 instead. And it is ready for review. Could you please review again? Thanks! |
Thank you @zhangfengcdt, the latest changes are great. |
Fixes #27031.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.