Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseDMLE2EIT and insert select statement parse logic #28457

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Refactor BaseDMLE2EIT and insert select statement parse logic #28457

merged 1 commit into from
Sep 18, 2023

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Sep 18, 2023 •
edited
Loading

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Refactor BaseDMLE2EIT and insert select statement parse logic

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.1 milestone Sep 18, 2023
@zhaojinchao95 zhaojinchao95 merged commit 3cbd841 into apache:master Sep 18, 2023
82 checks passed
@strongduanmu strongduanmu deleted the dev-0918 branch September 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees
No one assigned
Labels
in: test type: refactor
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@strongduanmu @zhaojinchao95