Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oracle insert and alter table parse error #28467

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Fix oracle insert and alter table parse error #28467

merged 4 commits into from
Sep 24, 2023

Conversation

zihaoAK47
Copy link
Member

Fixes #28317.

Changes proposed in this pull request:

  • Fix oracle insert and alter table parse error
  • Add test sql

Before committing this PR, I'm sure that I have checked the following options:

  • [ ✓] My code follows the code of conduct of this project.
  • [ ✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [ ✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [ ✓] I have added corresponding unit tests for my changes.

@zihaoAK47
Fix oracle insert and alter table parse error
dd41434
@zihaoAK47
Change addColumnSpecification define
27d4aee
@zihaoAK47
Add modify constraint definition test
530d7a2
@zihaoAK47
Merge branch 'master' into dev_28317
c40b05f 
# Conflicts:
#	test/it/parser/src/main/resources/case/dml/insert.xml
#	test/it/parser/src/main/resources/sql/supported/dml/insert.xml
@strongduanmu strongduanmu added this to the 5.4.2 milestone Sep 24, 2023
strongduanmu
strongduanmu approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, merged.

@strongduanmu strongduanmu merged commit a902754 into apache:master Sep 24, 2023
127 checks passed
@strongduanmu
Copy link
Member

Hi @zihaoAK47, can you comment on the original issue?

@zihaoAK47 zihaoAK47 deleted the dev_28317 branch September 25, 2023 01:30
@taojintianxia taojintianxia modified the milestones: 5.4.2, 5.4.1 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: Oracle in: SQL parse type: enhancement
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.

Some Oracle SQLs are not parsed correctly of ShardingSphere-Proxy
3 participants
@zihaoAK47 @strongduanmu @taojintianxia