Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:DataSourcePoolDestroyerTest occasionally fails(#28550) #28553

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Fix:DataSourcePoolDestroyerTest occasionally fails(#28550) #28553

merged 2 commits into from
Sep 24, 2023

Conversation

lujx98
Copy link
Contributor

@lujx98 lujx98 commented Sep 22, 2023

Fixes #28550.

Changes proposed in this pull request:

  • remove DataSourcePoolDestroyerTest assertion

Before committing this PR, I'm sure that I have checked the following options:

  • [✓] My code follows the code of conduct of this project.
  • [✓ ] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@zhaojinchao95 zhaojinchao95 added this to the 5.4.2 milestone Sep 23, 2023
@zhaojinchao95 zhaojinchao95 merged commit 745d259 into apache:master Sep 24, 2023
15 checks passed
@taojintianxia taojintianxia modified the milestones: 5.4.2, 5.4.1 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees
No one assigned
Labels
in: test
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.

DataSourcePoolDestroyerTest unit test fails occasionally
3 participants
@lujx98 @zhaojinchao95 @taojintianxia