Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for WithSegment #28555

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Support for WithSegment #28555

merged 1 commit into from
Sep 26, 2023

Conversation

kanha-gupta
Copy link
Contributor

@kanha-gupta kanha-gupta commented Sep 22, 2023 •
edited
Loading

Ref #28328

  • Support for SQLServer conversion
  • Support for WithSegment and Test cases -
    -delete_with_with_clause
    -delete_without_columns_with_with_clause

strongduanmu
strongduanmu approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kanha-gupta, can you take a look at checkstyle?

strongduanmu
strongduanmu requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kanha-gupta, can you take a look at checkstyle?

@kanha-gupta kanha-gupta force-pushed the withSegment branch 2 times, most recently from 7dd47d5 to 550fc0d Compare September 25, 2023 12:47
@kanha-gupta
Copy link
Contributor Author

kanha-gupta commented Sep 25, 2023 •
edited
Loading

@strongduanmu Hey, Checkstyle is resolved now. With Converter Class is made to convert various SQL statements such as Insert, delete, update therefore Constructor takes parameters of WithSegment and query(SqlNode)

@strongduanmu strongduanmu added this to the 5.4.1 milestone Sep 26, 2023
@strongduanmu strongduanmu merged commit 898dcc9 into apache:master Sep 26, 2023
127 checks passed
@kanha-gupta kanha-gupta deleted the withSegment branch October 17, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
feature: SQL federation type: enhancement
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kanha-gupta @strongduanmu