Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add : add check profile to validate the code #28572

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Add : add check profile to validate the code #28572

merged 4 commits into from
Sep 25, 2023

Conversation

taojintianxia
Copy link
Contributor

@taojintianxia taojintianxia commented Sep 25, 2023 •
edited
Loading

Changes proposed in this pull request:

  • add check profile to validate the code

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@taojintianxia taojintianxia added this to the 5.4.2 milestone Sep 25, 2023
@taojintianxia taojintianxia marked this pull request as draft September 25, 2023 02:32
@taojintianxia taojintianxia marked this pull request as ready for review September 25, 2023 03:57
@RaigorJiang RaigorJiang merged commit f16a1e6 into apache:master Sep 25, 2023
127 checks passed
@taojintianxia taojintianxia deleted the update-dependencies branch September 25, 2023 05:15
@taojintianxia taojintianxia modified the milestones: 5.4.2, 5.4.1 Sep 27, 2023
aniska123 added a commit to aniska123/shardingsphere that referenced this pull request Oct 20, 2023
@aniska123
profile.py
17b0192 
Resolved Add : add check profile to validate the code (apache#28572)
aniska123 added a commit to aniska123/shardingsphere that referenced this pull request Oct 20, 2023
@aniska123
Create profile.py
2fba964 
Resolved Add : add check profile to validate the code (apache#28572)
This was referenced Oct 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaigorJiang RaigorJiang RaigorJiang approved these changes

Assignees
No one assigned
Labels
type: build
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@taojintianxia @RaigorJiang