Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Junit for ShardingSphereMetaData (#28564) #28576

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Junit for ShardingSphereMetaData (#28564) #28576

merged 2 commits into from
Sep 28, 2023

Conversation

sayyidhussain
Copy link
Contributor

@sayyidhussain sayyidhussain commented Sep 25, 2023 •
edited
Loading

Fixes #28564 .

Changes proposed in this pull request:
Added Junit

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@sayyidhussain sayyidhussain mentioned this pull request Sep 25, 2023
Closed
2 tasks
@zhaojinchao95 zhaojinchao95 added this to the 5.4.2 milestone Sep 28, 2023
@zhaojinchao95 zhaojinchao95 merged commit b103ffa into apache:master Sep 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees
No one assigned
Labels
in: test
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add more test cases on ShardingSphereMetaData
2 participants
@sayyidhussain @zhaojinchao95