Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for TableMetadataReviseEngine (#28535) #28627

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Added unit tests for TableMetadataReviseEngine (#28535) #28627

merged 1 commit into from
Dec 2, 2023

Conversation

gagan-gv
Copy link
Contributor

@gagan-gv gagan-gv commented Oct 3, 2023 •
edited
Loading

Fixes #28535.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation. (N/A)
  • I have added corresponding unit tests for my changes. (N/A)

@gagan-gv gagan-gv mentioned this pull request Oct 3, 2023
Closed
@gagan-gv
Copy link
Contributor Author

gagan-gv commented Oct 7, 2023

Hi, I've run all the pre-build checks and have updated the PR.

@zhaojinchao95 zhaojinchao95 added this to the 5.4.2 milestone Oct 16, 2023
@gagan-gv
Copy link
Contributor Author

gagan-gv commented Oct 17, 2023 •
edited
Loading

Hey @zhaojinchao95, I've made the changes. Please, have a look and do let me know if any changes are required.

@gagan-gv gagan-gv requested a review from strongduanmu October 27, 2023 15:08
@gagan-gv
Copy link
Contributor Author

gagan-gv commented Nov 2, 2023

Hi,
@strongduanmu, I have made the changes asked. Can you re-review the PR?

Thank you!

@gagan-gv
Copy link
Contributor Author

Hi,
Can someone review this PR?

Thank you

linghengqian
linghengqian approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gagan-gv
Copy link
Contributor Author

gagan-gv commented Nov 20, 2023 •
edited
Loading

Hey @strongduanmu , can you please review the PR.

Thank you!

@gagan-gv
Copy link
Contributor Author

Hi,
@strongduanmu can you review PR.
Thank you!

strongduanmu
strongduanmu approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit fa65d5b into apache:master Dec 2, 2023
15 checks passed
@gagan-gv gagan-gv deleted the 28535 branch December 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linghengqian linghengqian linghengqian approved these changes

@strongduanmu strongduanmu strongduanmu approved these changes

@zhaojinchao95 zhaojinchao95 Awaiting requested review from zhaojinchao95

Assignees
No one assigned
Labels
in: test
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add more unit tests for TableMetaDataReviseEngine
4 participants
@gagan-gv @strongduanmu @linghengqian @zhaojinchao95