Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unit tests for RuleMetaData.getInUsedStorageUnitNameAndRulesMap() #28724

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Added unit tests for RuleMetaData.getInUsedStorageUnitNameAndRulesMap() #28724

merged 13 commits into from
Mar 28, 2024

Conversation

Sakshi-75
Copy link
Contributor

@Sakshi-75 Sakshi-75 commented Oct 11, 2023 •
edited
Loading

Fixes #28681 .

Changes proposed in this pull request:

Added unit tests for RuleMetaData.getInUsedStorageUnitNameAndRulesMap()

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.2 milestone Oct 12, 2023
@strongduanmu
Copy link
Member

Hi @Sakshi-75, can you run mvn checkstyle:check -Pcheck -T1C on your local machine to fix ci exception?

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , sure

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , I ran the command but it only told me that the check failed in the infra package, it didn't tell me what the exact issues were. I tried to find the checkstyle report as well but the checkstyle-result.xml file that I found was empty. Can you help me in figuring out which particular checkstyle rules my code is failing?

@strongduanmu
Copy link
Member

Hi @strongduanmu , I ran the command but it only told me that the check failed in the infra package, it didn't tell me what the exact issues were. I tried to find the checkstyle report as well but the checkstyle-result.xml file that I found was empty. Can you help me in figuring out which particular checkstyle rules my code is failing?

Hi @Sakshi-75, You only need to query the log in front of the error message to find the class with the checkstyle problem.

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , I've fixed the issues and pushed the changes. Before pushing I ran the checkstyle check on my local to make sure there were no more errors.

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , I've made all the requested changes.

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , I've made the requested changes.

@Sakshi-75
Copy link
Contributor Author

Hi @strongduanmu , any more changes needed in this?

@strongduanmu strongduanmu merged commit 202d87f into apache:master Mar 28, 2024
15 checks passed
@strongduanmu strongduanmu mentioned this pull request Mar 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
in: metadata in: test
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add test cases for RuleMetaData.getInUsedStorageUnitNameAndRulesMap()
2 participants
@Sakshi-75 @strongduanmu