Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test in GovernanceRepositoryAPIImplTest #28747

Conversation

pavanbaloju
Copy link
Contributor

@pavanbaloju pavanbaloju commented Oct 13, 2023

Fixes #28544 .

Changes proposed in this pull request:

  • Adds unit test for persistJobOffsetInfo, getJobOffsetInfo methods

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@zhaojinchao95 zhaojinchao95 added this to the 5.4.2 milestone Oct 13, 2023
@zhaojinchao95
Copy link
Contributor

Please fix ci, you need to check ci in your local environment,you can refer to : https://shardingsphere.apache.org/community/en/involved/conduct/code/

@pavanbaloju
Copy link
Contributor Author

Please fix ci, you need to check ci in your local environment,you can refer to : https://shardingsphere.apache.org/community/en/involved/conduct/code/

I fixed the formatting and ./mvnw spotless:apply -Pcheck command shows build successful in local

@zhaojinchao95 zhaojinchao95 merged commit b8427b8 into apache:master Oct 15, 2023
15 checks passed
@pavanbaloju pavanbaloju deleted the add-unit-test-GovernanceRepositoryAPIImpl branch October 15, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for GovernanceRepositoryAPIImpl persistJobOffsetInfo, getJobOffsetInfo
2 participants