Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataSourceProperties from the result set of ShowStorageUnitExecutor #28764

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Oct 15, 2023

Fixes #28703 , remove dataSourceProperties from the result set of ShowStorageUnitExecutor.

Changes proposed in this pull request:

  • Refactor ShowStorageUnitExecutor
  • Update test cases

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

yx9o added 2 commits October 16, 2023 22:41
# Conflicts:
#	test/e2e/sql/src/test/resources/cases/ral/dataset/empty_rules/mysql/show_storage_units.xml
#	test/e2e/sql/src/test/resources/cases/ral/dataset/empty_rules/opengauss/show_storage_units.xml
#	test/e2e/sql/src/test/resources/cases/ral/dataset/empty_rules/postgresql/show_storage_units.xml
@RaigorJiang RaigorJiang merged commit 9bbcfba into apache:master Oct 16, 2023
133 checks passed
@yx9o yx9o deleted the dev-28703 branch October 17, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dataSourceProperties from the result set of ShowStorageUnitExecutor
2 participants