Change the definition position of the create table SelectStatement class #28808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Oct 20, 2023
| @@ -36,7 +38,18 @@ public abstract class CreateTableStatement extends AbstractSQLStatement implemen | |||
|
|
|||
| private SimpleTableSegment table; | |||
|
|
|||
| private SelectStatement selectStatement; | |||
There was a problem hiding this comment.
Why move selectStatement to CreateTableStatement?
There was a problem hiding this comment.
Hi, mentor. When analyzing the SQL format of "CREATE TABLE AS SELECT" statement in MySQL, I found that Oracle, SQL Server, OpenGauss, and PostgreSQL all support similar SQL formats. The SelectStatement is currently defined in the SQLServerCreateTableStatement. Should we move the SelectStatement to the CreateTableStatement class for definition?
There was a problem hiding this comment.
Yes, commen segment should be moved to super class.
strongduanmu
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #28752.
Changes proposed in this pull request:
create table as selectformatBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.