Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some segment to dialect package and rename ColumnWithJoinOperatorSegment to OuterJoinExpression #28813

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Move some segment to dialect package and rename ColumnWithJoinOperatorSegment to OuterJoinExpression #28813

merged 1 commit into from
Oct 20, 2023

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Oct 20, 2023 •
edited
Loading

Ref #28799.

Changes proposed in this pull request:

  • move some segment to dialect package
  • rename ColumnWithJoinOperatorSegment to OuterJoinExpression

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.2 milestone Oct 20, 2023
@FlyingZC FlyingZC merged commit 32fa879 into apache:master Oct 20, 2023
133 checks passed
@strongduanmu strongduanmu deleted the dev-10202 branch October 20, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlyingZC FlyingZC FlyingZC approved these changes

Assignees
No one assigned
Labels
in: SQL parse type: refactor
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@strongduanmu @FlyingZC