Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28537 Add more unit tests for ConstraintReviseEngine #28846

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

anogueiraFlywire
Copy link
Contributor

Fixes #28537.

Changes proposed in this pull request:

  • Add more unit tests for ConstraintReviseEngine

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation - N/A
  • I have added corresponding unit tests for my changes. - N/A

@anogueiraFlywire
Copy link
Contributor Author

Please add the corresponding labels or let me know how to do it myself

@anogueiraFlywire anogueiraFlywire force-pushed the 28537 branch 2 times, most recently from 7c4cc21 to eb2da4b Compare October 23, 2023 08:00
@anogueiraFlywire
Copy link
Contributor Author

@tuichenchuxin Can you please review this?

@terrymanu terrymanu added this to the 5.5.0 milestone Mar 27, 2024
@terrymanu terrymanu merged commit d17c4c4 into apache:master Mar 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more unit tests for ConstraintReviseEngine
3 participants