Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline E2E compatible with com.mysql:mysql-connector-j:8.0 #28853

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

sandynz
Copy link
Contributor

@sandynz sandynz commented Oct 24, 2023

Related to #28849.

After discussing with @RaigorJiang , there're 2 workarounds. Use statement.execute and then getResultSet is an easier way, so it's used for now.

Changes proposed in this pull request:

  • Pipeline E2E use statement.execute and getResultSet to compatible with com.mysql:mysql-connector-j:8.0 for extended DistSQL
  • Revert pipeline E2E compatibility code of com.mysql:mysql-connector-j:8.0

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@azexcy azexcy merged commit 607ba11 into apache:master Oct 24, 2023
13 checks passed
@sandynz sandynz deleted the pipeline-1 branch October 24, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants