Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of customSqlUpdate to support FROM #28866

Closed
wants to merge 1 commit into from

Conversation

kanha-gupta
Copy link
Contributor

Ref #28328

Changes proposed in this pull request:
Added customSqlUpdate logic to parse SQL format ->
WITH CTE AS (
SELECT order_id
FROM SomeOtherTable
WHERE some_condition
)
UPDATE t
SET t.status = ?
FROM
WHERE

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@kanha-gupta
Copy link
Contributor Author

@strongduanmu Please review :)

@kanha-gupta
Copy link
Contributor Author

Hi @strongduanmu Any updates ? The new class can handle all the statements but another approach is that I can optimize to only call the custom logic class if Statements involving FROM clause are called.

@kanha-gupta kanha-gupta deleted the withUpdate branch January 6, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants