Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotExpressionBinder unit test added #28881

Merged
merged 1 commit into from
Jan 24, 2024
Merged

NotExpressionBinder unit test added #28881

merged 1 commit into from
Jan 24, 2024

Conversation

Sakshi-75
Copy link
Contributor

@Sakshi-75 Sakshi-75 commented Oct 27, 2023 •
edited
Loading

Fixes #28504

Changes proposed in this pull request:

Added unit tests for NotExpressionBinder.java

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.5.0 milestone Jan 24, 2024
strongduanmu
strongduanmu approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, this pr is great.

@strongduanmu strongduanmu merged commit 93f8b10 into apache:master Jan 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
in: kernel in: test
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add more unit tests for NotExpressionBinder
2 participants
@Sakshi-75 @strongduanmu