Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing Oracle CREATE LIBRARY SQL #28920

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Support parsing Oracle CREATE LIBRARY SQL #28920

merged 3 commits into from
Nov 3, 2023

Conversation

chakkk309
Copy link
Contributor

@chakkk309 chakkk309 commented Nov 2, 2023 •
edited
Loading

Fixes #27030 and ref #26878

Changes proposed in this pull request:

  • Support Oracle create-library SQL syntax
  • Add test

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.4.2 milestone Nov 3, 2023
strongduanmu
strongduanmu approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged.

@strongduanmu strongduanmu merged commit 58b2a2a into apache:master Nov 3, 2023
133 checks passed
@chakkk309 chakkk309 deleted the create-library branch November 3, 2023 04:24
@chakkk309 chakkk309 restored the create-library branch November 3, 2023 04:24
@chakkk309 chakkk309 deleted the create-library branch November 3, 2023 04:24
@chakkk309 chakkk309 restored the create-library branch November 3, 2023 04:24
@chakkk309 chakkk309 deleted the create-library branch November 3, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: Oracle in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Support parsing Oracle CREATE LIBRARY sql
2 participants
@chakkk309 @strongduanmu