Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle select union statement parse test #29015

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

zihaoAK47
Copy link
Member

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Add complex select union query statement parsing test
  • Add multiple union statement parsing test
  • Add multiple union priority test
  • Priority Description Reference link
    2023-11-12_20-45

Before committing this PR, I'm sure that I have checked the following options:

  • [ ✓] My code follows the code of conduct of this project.
  • [ ✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [ ✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [ ✓] I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member

Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.

@zihaoAK47
Copy link
Member Author

Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.

Hi mentor, I have submitted a new parsing code.
The following is a preview image of Antlr parsing

1
2

@strongduanmu
Copy link
Member

strongduanmu commented Nov 14, 2023

Hi @zihaoAK47, can you show antlr preview for more than one union statement? It seems that the priority processing of multiple Union statements is wrong.

Hi mentor, I have submitted a new parsing code. The following is a preview image of Antlr parsing

1 2

@zihaoAK47 Now the result of sql parser is correct, thank you for correct it.

@strongduanmu strongduanmu merged commit 0cbc2da into apache:master Nov 14, 2023
133 checks passed
@zihaoAK47 zihaoAK47 deleted the sql_parse_test branch November 15, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants