Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oracle create view attribute parse rule #29057

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

zihaoAK47
Copy link
Member

Fixes #27122.

Changes proposed in this pull request:

  • Fix oracle attribute parse rule
  • Add oracle create view parse sql test
  • Add oracle insert parse sql test

Before committing this PR, I'm sure that I have checked the following options:

  • [✓] My code follows the code of conduct of this project.
  • [✓] I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • [✓] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • [✓] I have added corresponding unit tests for my changes.

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merged.

@strongduanmu strongduanmu merged commit 4983e94 into apache:master Nov 17, 2023
133 checks passed
@zihaoAK47 zihaoAK47 deleted the dev branch November 17, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parsing Oracle CREATE VIEW sql
2 participants