Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interval implementation of InlineExpressionParser SPI #29309

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 6, 2023

Fixes #22899.

Changes proposed in this pull request:

  • Add Interval implementation of InlineExpressionParser SPI.
  • The function signature of this SPI uses java.util.List instead of java.util.Collection, which should require another PR to correct the function signature.
  • Since the JDK 8 version is used in CI is too old, the relevant java.time.chrono.JapaneseDate tests have been set up to be available for JDK11+.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the new-expr-time branch 7 times, most recently from 1ebdf52 to 9d6296b Compare December 6, 2023 19:01
@linghengqian linghengqian marked this pull request as ready for review December 6, 2023 21:15
@linghengqian linghengqian changed the title Add Interval implementation of InlineExpressionParser SPI Add Interval and IntervalJapaneseDate implementation of InlineExpressionParser SPI Dec 7, 2023
@linghengqian linghengqian force-pushed the new-expr-time branch 2 times, most recently from 946efc9 to 79aa991 Compare December 7, 2023 06:40
@linghengqian linghengqian changed the title Add Interval and IntervalJapaneseDate implementation of InlineExpressionParser SPI Add Interval implementation of InlineExpressionParser SPI Dec 7, 2023
@linghengqian linghengqian force-pushed the new-expr-time branch 9 times, most recently from 22d7be4 to b1584f8 Compare December 12, 2023 02:34
@terrymanu terrymanu added this to the 5.4.2 milestone Dec 12, 2023
@terrymanu terrymanu merged commit 440064a into apache:master Dec 12, 2023
133 checks passed
@linghengqian linghengqian deleted the new-expr-time branch December 12, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants