-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shadow moudle throw 'Table does not exist' exception #31378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI
|
||
private final CaseInsensitiveSet<String> logicalTableMapper; | ||
|
||
public ShadowTableMapperRuleAttribute(final Collection<String> encryptTableNames) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encryptTableNames
should not here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your review. It was my carelessness that caused this issue. I have adjusted the variable names and want to express my gratitude again.
@TherChenYang Hi, #31360 configuration has problem, so can you close this pr? |
@zhaojinchao95 Okay, I will close this PR. Do we need to make corresponding adjustments to our example module and official documentation for users to access it more quickly? |
Yes, would you like to adjustment example? |
@zhaojinchao95 Okay, thank you very much. I will adjust the corresponding documents and examples |
Fixes #31360.
Changes proposed in this pull request:
created ahead of time and not through ShardingSphereConection, an error is thrown
TableNotFoundException: Table or view ‘t_order’ does not exist.
For Example
-- After modification
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.