Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes utility functions that are no longer used due to ClickHouse's nativeTest refactoring #32577

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Removes utility functions that are no longer used due to ClickHouse's nativeTest refactoring #32577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/TestShardingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public void deleteDataInClickHouse(final Collection<Long> orderIds) throws SQLEx
public void deleteDataInHive() throws SQLException {
long count = 1L;
for (int i = 1; i <= 10; i++) {
addressRepository.deleteInHive(count++);
addressRepository.delete(count++);
}
}

Expand Down
16 changes: 0 additions & 16 deletions ...ava/org/apache/shardingsphere/test/natived/jdbc/commons/repository/AddressRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,22 +152,6 @@ public void delete(final Long id) throws SQLException {
}
}

/**
* delete by id.
*
* @param id id
* @throws SQLException SQL exception
*/
public void deleteInHive(final Long id) throws SQLException {
String sql = "DELETE FROM t_address WHERE address_id=?";
try (
Connection connection = dataSource.getConnection();
PreparedStatement preparedStatement = connection.prepareStatement(sql)) {
preparedStatement.setLong(1, id);
preparedStatement.executeUpdate();
}
}

/**
* delete by id in ClickHouse.
*
Expand Down