Optimize MySQL INSERT INTO VALUES AS row_alias parse SQLStatement #36680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strongduanmu
requested changes
Sep 26, 2025
| : INSERT insertSpecification INTO? tableName partitionNames? insertBody onDuplicateKeyClause? returningClause? | ||
| ; | ||
|
|
||
| insertBody : insertValuesClause | setAssignmentsClause valueReference? | insertSelectClause valueReference? ; |
There was a problem hiding this comment.
Please put the content after : on a new line.
| result.setInsertColumns(new InsertColumnsSegment(ctx.start.getStartIndex() - 1, ctx.start.getStartIndex() - 1, Collections.emptyList())); | ||
| } | ||
| result.getValues().addAll(createInsertValuesSegments(ctx.assignmentValues())); | ||
|
|
There was a problem hiding this comment.
Please remove useless blank line.
| ValueReferenceSegment valueRef = (ValueReferenceSegment) visit(ctx.valueReference()); | ||
| result.setValueReference(valueRef); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove useless blank line.
|
|
||
| @Override | ||
| public ASTNode visitRowAlias(final RowAliasContext ctx) { | ||
| return new CommonExpressionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), ctx.getText()); |
There was a problem hiding this comment.
Why return CommonExpressionSegment?
There was a problem hiding this comment.
May use RowAliasSegment here is better.
| } | ||
| return new SetAssignmentSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), assignments); | ||
| SetAssignmentSegment setAssignment = new SetAssignmentSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), assignments); | ||
| return setAssignment; |
There was a problem hiding this comment.
Please remove setAssignment and return new xxx directly.
|
Hi @strongduanmu , this pr is ready to review~ |
Ok, I will review this pr later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36583.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.