[type:refactor]Decouple apidoc module from rule and selector modules #5685
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,6 @@ | |
| import org.apache.shenyu.admin.utils.ShenyuResultMessage; | ||
| import org.apache.shenyu.common.constant.AdminConstants; | ||
| import org.apache.shenyu.common.dto.RuleData; | ||
| import org.apache.shenyu.common.utils.GsonUtils; | ||
| import org.apache.shenyu.common.utils.UUIDUtils; | ||
| import org.apache.shenyu.register.common.dto.ApiDocRegisterDTO; | ||
|
|
@@ -110,6 +109,7 @@ public String createOrUpdate(final ApiDTO apiDTO) { | |
| * @return update message | ||
| */ | ||
| private String update(final ApiDTO apiDTO) { | ||
| //cdbuild apiDO | ||
| ApiDO apiDO = ApiDO.buildApiDO(apiDTO); | ||
| final int updateRows = apiMapper.updateByPrimaryKeySelective(apiDO); | ||
| if (updateRows > 0) { | ||
|
|
@@ -126,11 +126,6 @@ private String update(final ApiDTO apiDTO) { | |
| tagRelationMapper.deleteByApiId(apiDO.getId()); | ||
| tagRelationMapper.batchInsert(tags); | ||
| } | ||
|
There was a problem hiding this comment. When creating apidoc, this part determines whether the document is in the published state, and if the document is in the published state, the selector is registered, etc. If it is in the offline state, the corresponding selector content is deleted, which will lead to the coupling of apidoc and selector. Deleting this part can release their coupling. The removal of this feature will have the following effects, the document publication and logout will only be displayed as a status without additional functions, the document logout and online need to manually add and delete selectors and other content, for the creation of api documents, Users using @RequestMapping and other annotations and users using swagger will automatically create selectors and other content through annotations, which will not affect the convenience brought by automation. To add api documents in the visual interface, you need to manually create corresponding selector, rule, and Metadata. For the offline api document, all users need to manually delete the corresponding selector, rule, and Metadata |
||
| } | ||
| return ShenyuResultMessage.UPDATE_SUCCESS; | ||
| } | ||
|
|
@@ -158,9 +153,6 @@ private String create(final ApiDTO apiDTO) { | |
| .build()).collect(Collectors.toList()); | ||
| tagRelationMapper.batchInsert(tags); | ||
| } | ||
| } | ||
| return ShenyuResultMessage.CREATE_SUCCESS; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add this？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, my previous submission failed to check the instability of ci. I hope I can re-trigger ci through some modifications. If these modifications cause bad effects, I will delete them