Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect documention links of EOL versions to Apache Archive Service #550

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Aug 26, 2024

This PR redirects all the versions circled in red in the figure below to the Apache Archive Service.

Screen.Recording.2024-08-26.at.13.36.02.mov

0.6.x & 0.7.x are kept here as they seem not to be ASF releases
3.4.x, 3.5.x & 4.0.x are kept here as they are not EOL.

image

@dongjoon-hyun
Copy link
Member

Thank you, @yaooqinn .

@dongjoon-hyun
Copy link
Member

cc @srowen

@yaooqinn
Copy link
Member Author

Redirecting…

Click here if you are not redirected.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@yaooqinn yaooqinn merged commit ac7a93b into apache:asf-site Aug 26, 2024
1 check passed
@yaooqinn yaooqinn deleted the archive branch August 26, 2024 06:32
@yaooqinn
Copy link
Member Author

Merged to asf-site.

Thank you @dongjoon-hyun

@allisonwang-db
Copy link
Contributor

@yaooqinn it doesn't seem to redirect to the archive service and breaks Google search result:
https://spark.apache.org/docs/3.1.1/api/python/reference/api/pyspark.sql.DataFrame.dropDuplicates.html
Screenshot 2024-08-26 at 13 49 30
Screenshot 2024-08-26 at 13 49 46
Also for keyword "pyspark groupby"

@yaooqinn
Copy link
Member Author

Do you know why the Google searcher were looking for these items from 3.1 instead of newer ones such as 3.4 or 3.5

@dongjoon-hyun
Copy link
Member

To @allisonwang-db , this PR doesn't mean that we implement a redirection from old Apache Spark links to the archive locations. I believe Google search engine index will be updated gradually.

@allisonwang-db
Copy link
Contributor

I’m afraid that this could seriously impact the PySpark user experience, with an invalid documentation link appearing as the top Google search result for very common keywords.

cc @MrPowers, do you know how long it typically takes for Google’s search index to update?

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 27, 2024

I’m afraid that this could seriously impact the PySpark user experience, with an invalid documentation link appearing as the top Google search result for very common keywords.

cc @MrPowers, do you know how long it typically takes for Google’s search index to update?

To @allisonwang-db , we already discussed about the risk in the dev mailing list and decided to move only old End-Of-Support docs. Please see the scope of the PR. All live releases documents are available without any change. Given that, I don't think there is any real impact on the PySpark user experience due to this the End-Of-Support documentation link change. This is a legit maintenance activity on the end-of-support artifacts.

@HyukjinKwon
Copy link
Member

I am fine with the PR itself but just probably a dumb question. Why doesn't the redirection work?

@yaooqinn
Copy link
Member Author

The redirection pages, such as https://github.com/apache/spark-website/blob/asf-site/site/docs/0.8.0/index.html, are created only for the home pages of each version of docs

@yaooqinn
Copy link
Member Author

I have created a follow-up #552 to enhance the UX. This is the best effort I can do for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants