Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warnings for numIterations * miniBatchFraction < 1.0 #13265

Closed
wants to merge 2 commits into from
Closed

Log warnings for numIterations * miniBatchFraction < 1.0 #13265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7dd4c6
Log warnings for numIterations * miniBatchFraction < 1.0 during gradi…
May 23, 2016
0754ce0
Add current numIterations and miniBatchFraction values to warning log
May 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ object GradientDescent extends Logging {
"< 1.0 can be unstable because of the stochasticity in sampling.")
}

if (numIterations * miniBatchFraction < 1.0) {
logWarning("Not all examples will be used if numIterations * miniBatchFraction < 1.0: " +
s"numIterations=$numIterations and miniBatchFraction=$miniBatchFraction")
}

val stochasticLossHistory = new ArrayBuffer[Double](numIterations)
// Record previous weight and current one to calculate solution vector difference

Expand Down