[SPARK-22866] [K8S] Fix path issue in Kubernetes dockerfile #20051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path was recently changed in apache#19946, but the dockerfile was not updated.
mridulm
reviewed
Dec 22, 2017
| @@ -38,7 +38,7 @@ COPY jars /opt/spark/jars | |||
| COPY bin /opt/spark/bin | |||
| COPY sbin /opt/spark/sbin | |||
| COPY conf /opt/spark/conf | |||
| COPY dockerfiles/spark-base/entrypoint.sh /opt/ | |||
| COPY kubernetes/dockerfiles/spark-base/entrypoint.sh /opt/ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, to elaborate, on our fork, we used to have dockerfiles/ in the root of the built distribution. But now, it's copied to kubernetes/dockerfiles which is a more logical place, since there is a yarn/ in the distribution as well.
|
A grep indicates this is the full list:
|
|
@mridulm thanks for looking into it! Looks like I missed updating the dockerfile comments. On it. |
|
Done, comments updated. I'm setting up CI on the Kubernetes test infrastructure this week - should help catch these issues early on in future. |
|
Merged, thanks @foxish |
|
Test build #85294 has finished for PR 20051 at commit
|
|
Test build #85297 has finished for PR 20051 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The path was recently changed in #19946, but the dockerfile was not updated.
This is a trivial 1 line fix.
How was this patch tested?
./sbin/build-push-docker-images.sh -r spark-repo -t latest buildcc/ @vanzin @mridulm @rxin @jiangxb1987 @liyinan926