Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45043][BUILD] Upgrade scalafmt to 3.7.13 #42764

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

The pr aims to upgrade scalafmt from 3.7.5 to 3.7.13.

Why are the changes needed?

1.The newest version include some bug fixed, eg:

2.The full release notes:
https://github.com/scalameta/scalafmt/releases/tag/v3.7.13
https://github.com/scalameta/scalafmt/releases/tag/v3.7.12
https://github.com/scalameta/scalafmt/releases/tag/v3.7.11
https://github.com/scalameta/scalafmt/releases/tag/v3.7.10
https://github.com/scalameta/scalafmt/releases/tag/v3.7.9
https://github.com/scalameta/scalafmt/releases/tag/v3.7.8
https://github.com/scalameta/scalafmt/releases/tag/v3.7.7
https://github.com/scalameta/scalafmt/releases/tag/v3.7.6

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@srowen
Copy link
Member

srowen commented Sep 2, 2023

I think this is fine to update plugins in general. Some stuff like this doesn't seem like it does anything for Spark, so isn't that important. As long as we're not generating a whole lot of PRs, it's OK

@srowen srowen closed this in 82d54fc Sep 2, 2023
@srowen
Copy link
Member

srowen commented Sep 2, 2023

Merged to master

@panbingkun
Copy link
Contributor Author

I think this is fine to update plugins in general. Some stuff like this doesn't seem like it does anything for Spark, so isn't that important. As long as we're not generating a whole lot of PRs, it's OK

Okay, I see👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants