[SPARK-50557][CONNECT][SQL] Support RuntimeConfig.contains(..) in Scala SQL Interface #49836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 7, 2025
HyukjinKwon
reviewed
Feb 7, 2025
| @@ -99,6 +99,11 @@ abstract class RuntimeConfig { | |||
| */ | |||
| private[sql] def get[T](entry: ConfigEntry[T], default: T): T | |||
|
|
|||
| /** | |||
| * Returns whether a particular key is set. | |||
There was a problem hiding this comment.
I think we should probably write a little bit more, e.g., if the configurations are known with default values, it will return true.
There was a problem hiding this comment.
I am pretty sure it does not.
|
Merging to master/branch-4.0 |
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2025
…la SQL Interface ### What changes were proposed in this pull request? This PR restores support for the `contains(..)` method in the `org.apache.spark.sql.RuntimeConfig` interface. ### Why are the changes needed? This method was used quite a lot in 3rd party libraries. We are adding it back to reduce friction. ### Does this PR introduce _any_ user-facing change? No, technically this is an internal method :)... ### How was this patch tested? I added a test for Connect to the `SessionE2ETestSuite` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49836 from hvanhovell/SPARK-50557. Authored-by: Herman van Hovell <[email protected]> Signed-off-by: Herman van Hovell <[email protected]> (cherry picked from commit c9720af) Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR restores support for the
contains(..)method in theorg.apache.spark.sql.RuntimeConfiginterface.Why are the changes needed?
This method was used quite a lot in 3rd party libraries. We are adding it back to reduce friction.
Does this PR introduce any user-facing change?
No, technically this is an internal method :)...
How was this patch tested?
I added a test for Connect to the
SessionE2ETestSuiteWas this patch authored or co-authored using generative AI tooling?
No.