[SPARK-51584][SQL] Add rule that pushes Project through Offset and Suite that tests it #50326
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Mar 19, 2025
...rc/test/scala/org/apache/spark/sql/catalyst/optimizer/PushProjectionThroughOffsetSuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 21, 2025
|
|
||
| val query1 = testRelation | ||
| .offset(5) | ||
| .select(Symbol("a"), Symbol("b"), 'c') |
There was a problem hiding this comment.
Suggested change
| .select(Symbol("a"), Symbol("b"), 'c') | |
| .select($"a", $"b", $"c") |
|
let's create a JIRA ticket for it |
I requested a JIRA account, so I will create it when I get approved. |
Pajaraja
changed the title
Created here: https://issues.apache.org/jira/browse/SPARK-51584. |
|
thanks, merging to master! |
SauronShepherd
pushed a commit
to SauronShepherd/spark
that referenced
this pull request
Mar 25, 2025
…ite that tests it ### What changes were proposed in this pull request? Add a new rule PushProjectionThroughOffset analogous to PushProjectionThroughLimit, that pushes projection nodes beneath Offset nodes. ### Why are the changes needed? Currently, if a Project node is above a Offset and Limit node, the Project will get pushed through the Limit node, but not the Offset node, and then the Offset and LocalLimit nodes won't get swapped, eliminating the optimization LocalLimit nets in this case. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Created PushProjectionThroughOffsetSuite to test this new rule. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50326 from Pajaraja/pavle-martinovic_data/ProjectionPushDownThroughLimit. Authored-by: pavle-martinovic_data <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new rule PushProjectionThroughOffset analogous to PushProjectionThroughLimit, that pushes projection nodes beneath Offset nodes.
Why are the changes needed?
Currently, if a Project node is above a Offset and Limit node, the Project will get pushed through the Limit node, but not the Offset node, and then the Offset and LocalLimit nodes won't get swapped, eliminating the optimization LocalLimit nets in this case.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Created PushProjectionThroughOffsetSuite to test this new rule.
Was this patch authored or co-authored using generative AI tooling?
No.