[SPARK-52232][SQL] Fix non-deterministic queries to produce different results at every step #50957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… results at every step
cloud-fan
reviewed
May 22, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/UnionLoopExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/UnionLoopExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/core/src/test/resources/sql-tests/results/cte-recursion.sql.out
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/RecursiveCTESuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
May 22, 2025
sql/core/src/test/scala/org/apache/spark/sql/execution/RecursiveCTESuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
May 22, 2025
cloud-fan
reviewed
May 22, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/UnionLoopExec.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable deterministic queries to work with rCTEs. Fix bug where non-deterministic queries produce same result every iteration.
Why are the changes needed?
Currently, recursive CTEs create a new plan for each iteration of the recursion, so the expressions that use randomness "roll-back" to their initial value, causing things like "rand()" to produce the same result every time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests in golden files.
Was this patch authored or co-authored using generative AI tooling?
No.