[SPARK-46941][SQL][3.5] Can't insert window group limit node for top-k computation if contains SizeBasedWindowFunction #51422
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…putation if contains SizeBasedWindowFunction ### What changes were proposed in this pull request? Don't insert window group limit node for top-k computation if contains `SizeBasedWindowFunction`. ### Why are the changes needed? Bug fix, Insert window group limit node for top-k computation contains `SizeBasedWindowFunction` will cause wrong result of the SizeBasedWindowFunction`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New UT. Before this pr UT will not pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44980 from zml1206/SPARK-46941. Authored-by: zml1206 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
Can we copy-paste the full PR description from the original PR and then put |
cloud-fan
approved these changes
Jul 9, 2025
updated |
|
cc @peter-toth |
|
@cloud-fan @dongjoon-hyun CI failures appear unrelated, if you have no other comments, could you please merge it? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR backports #44980 to branch-3.5.
Don't insert window group limit node for top-k computation if contains
SizeBasedWindowFunction.Why are the changes needed?
Bug fix, Insert window group limit node for top-k computation contains
SizeBasedWindowFunctionwill cause wrong result of the SizeBasedWindowFunction`.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT. Before this pr UT will not pass.
Was this patch authored or co-authored using generative AI tooling?
No.