[SPARK-53290][SQL][CONNECT] Fix Metadata backward-compatibility breaking #52037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
changed the title
dongjoon-hyun
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
cc @aokolnychyi and @cloud-fan from SPARK-51987 which introduced this changed originally before.
|
Merged to master for Apache Spark 4.1.0 to recover the compatibility. |
|
thanks for the fix! |
mzhang
pushed a commit
to mzhang/spark
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request?
This PR adds the SerialVersionUID annotation and moves the newly added runtimeMap out from the ctor.
### Why are the changes needed?
With a v400 client to a v410 server, ```java.io.InvalidClassException: org.apache.spark.sql.types.Metadata;``` raised
```
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 4.0.0
/_/
Type in expressions to have them evaluated.
Spark connect server version 4.1.0-SNAPSHOT.
Spark session available as 'spark'.
scala> import spark.implicits._
import spark.implicits._
scala> spark.catalog.listCatalogs().map(_.name)
res1: org.apache.spark.sql.connect.Dataset[String] = Invalid Dataframe; [INTERNAL_ERROR] Failed to unpack scala udf. SQLSTATE: XX000
```
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
```
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 4.0.0
/_/
Type in expressions to have them evaluated.
Spark connect server version 4.1.0-SNAPSHOT.
Spark session available as 'spark'.
scala> import spark.implicits._
import spark.implicits._
scala> spark.catalog.listCatalogs().map(_.name)
res1: org.apache.spark.sql.connect.Dataset[String] = [value: string]
scala> spark.catalog.listCatalogs().map(_.name).collect()
res2: Array[String] = Array("spark_catalog")
```
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#52037 from yaooqinn/SPARK-53290.
Authored-by: Kent Yao <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the SerialVersionUID annotation and moves the newly added runtimeMap out from the ctor.
Why are the changes needed?
With a v400 client to a v410 server,
java.io.InvalidClassException: org.apache.spark.sql.types.Metadata;raisedDoes this PR introduce any user-facing change?
no
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No