[SPARK-53849][BUILD] Upgrade Netty to 4.2.6.Final #52552
Closed
+46
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed. |
|
Could you review this PR when you have some time, please, @peter-toth ? |
sarutak
approved these changes
Oct 9, 2025
| -Djdk.reflect.useDirectMethodHandle=false | ||
| -Dio.netty.tryReflectionSetAccessible=true | ||
| -Dio.netty.allocator.type=pooled | ||
| -Dio.netty.handler.ssl.defaultEndpointVerificationAlgorithm=NONE |
There was a problem hiding this comment.
I understand these changes are for keeping behavior like Netty 4.1 and before as the migration guides indicates.
https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide
There was a problem hiding this comment.
Yes, correct. Thank you, @sarutak .
|
Merged to master for Apache Spark 4.1.0-preview3. |
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
Nettyto4.2.6.Finalas a part ofApache Spark 4.1.0preparation.This PR follows the official community migration guide.
Why are the changes needed?
Nettycommunity recommends4.2.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.