Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORM-4009 - Regenerate using thrift 0.18.1 #3608

Merged
merged 1 commit into from
Dec 7, 2023
Merged

STORM-4009 - Regenerate using thrift 0.18.1 #3608

merged 1 commit into from
Dec 7, 2023

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 6, 2023

What is the purpose of the change

  • Regenerate old thrift code with new thrift compiler for the sake of newer language features.

How was the change tested

  • CI

@rzo1 rzo1 requested a review from jnioche December 6, 2023 13:39
jnioche
jnioche approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzo1 rzo1 merged commit 9a238c4 into master Dec 7, 2023
18 checks passed
@rzo1 rzo1 deleted the STORM-4009 branch December 7, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnioche jnioche jnioche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzo1 @jnioche