Skip to content

Commit

Permalink
chore: Move extensions installation view to settings (#2919)
Browse files Browse the repository at this point in the history
* chore: Move extensions installation view to settings

* Fix navigation

* Fix cypress test
  • Loading branch information
dominikriemer authored Jun 7, 2024
1 parent c410d11 commit b02146b
Show file tree
Hide file tree
Showing 27 changed files with 268 additions and 358 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ for (var i = 0; i < testedRoles.length; i++) {
UserUtils.goToUserConfiguration();
cy.dataCy('navigation-icon', { timeout: 10000 }).should(
'have.length',
10,
9,
);

cy.dataCy('user-accounts-table-row', { timeout: 10000 }).should(
Expand Down
1 change: 0 additions & 1 deletion ui/deployment/dev/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ modules:
- spConnect
- spDashboard
- spDataExplorer
- spAdd
- spAssets
- spFiles
- spConfiguration
14 changes: 0 additions & 14 deletions ui/deployment/modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,6 @@ spPipelines:
homeImage: '/assets/img/home/pipelines.png'
admin: False
pageNames: 'PageName.PIPELINE_OVERVIEW'
spAdd:
componentImport: False
ng5_moduleName: 'AddModule'
ng5_component: 'AddComponent'
ng5_componentPath: './add/add.component'
path: './add/add.module'
link: 'add'
url: '/add'
title: 'Install Extensions'
description: 'The extension installation module can be used to install additional adapters, data streams, data processors, and sinks.'
icon: 'cloud_download'
homeImage: '/assets/img/home/add.png'
admin: True
pageNames: 'PageName.INSTALL_PIPELINE_ELEMENTS'
spConfiguration:
componentImport: False
ng5_moduleName: 'ConfigurationModule'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
</div>

<div
class="fixed-height page-container-padding-inner"
class="fixed-height"
[ngStyle]="{ padding: padding }"
fxLayout="column"
fxFlex="100"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
*
*/

.page-container-padding-inner {
padding: 10px;
}

.sp-bg-lightgray {
background-color: var(--color-bg-1);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export class SpBasicNavTabsComponent {
@Input()
backLinkTarget: string[] = [];

@Input()
padding = '10px';

constructor(private router: Router) {}

navigateTo(spNavigationItem: SpNavigationItem) {
Expand Down
184 changes: 0 additions & 184 deletions ui/src/app/add/add.component.html

This file was deleted.

96 changes: 0 additions & 96 deletions ui/src/app/add/add.module.ts

This file was deleted.

27 changes: 0 additions & 27 deletions ui/src/app/add/add.routes.ts

This file was deleted.

7 changes: 6 additions & 1 deletion ui/src/app/configuration/configuration-tabs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,14 @@ export class SpConfigurationTabs {
itemTitle: 'Export/Import',
itemLink: ['configuration', 'export'],
},
{
itemId: 'extensions-installation',
itemTitle: 'Extensions',
itemLink: ['configuration', 'extensions-installation'],
},
{
itemId: 'extensions-services',
itemTitle: 'Extensions Services',
itemTitle: 'Extension Services',
itemLink: ['configuration', 'extensions-services'],
},
{
Expand Down
Loading

0 comments on commit b02146b

Please sign in to comment.