Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(#2095): remove update button & move permissions button #2155

Closed
wants to merge 1 commit into from

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Nov 8, 2023

Purpose

see #2095

One pipeline element is displayed the following now:
image

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the ui Anything that affects the UI label Nov 8, 2023
@bossenti bossenti linked an issue Nov 8, 2023 that may be closed by this pull request
@dominikriemer
Copy link
Member

@bossenti one question, how will development work without the update button?
E.g., when I develop a pipeline element, I often modify configs and test them by using the update button. Will this still work with the new approach or would I need to increase the version with every change?

@bossenti
Copy link
Contributor Author

bossenti commented Nov 8, 2023

We do overwrite all adapter & pipeline element descriptions when starting an extensions service right?
If so, there should be no need to manually update the descriptions during development. Or am I mistaken?

@tenthe
Copy link
Contributor

tenthe commented Nov 8, 2023

@bossenti I'm not entirely certain if this is already the case, but I agree with you on how it should be.

@bossenti
Copy link
Contributor Author

I'll give it a final check before merging

@bossenti
Copy link
Contributor Author

I just did a quick check: pipeline element descriptions are only updated if there is a migration in place.
So for development purposes, we rely on this button or need to define a migration to update pipeline elements automatically

@bossenti
Copy link
Contributor Author

Which one do we want to take?

@dominikriemer
Copy link
Member

I'd prefer to keep the manual update button for now.
But I like the Manage Permissions button ;-)

@bossenti
Copy link
Contributor Author

Okay, fine for me
Me too, but there is no space for three buttons right?

@bossenti bossenti deleted the 2095-remove-update-functionality-from-ui branch April 8, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove update functionality from UI
3 participants