Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3247): Add waiting time and add test to smoke tests #3248

Merged

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Sep 24, 2024

Purpose

This PR renames the timeRangeSelectors test file to include it in the smoke test suite.
Additionally, a waiting time has been added to ensure the content is rendered.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe linked an issue Sep 24, 2024 that may be closed by this pull request
@github-actions github-actions bot added ui Anything that affects the UI testing Relates to any kind of test (unit test, integration, or E2E test). labels Sep 24, 2024
@tenthe tenthe merged commit c0dd74c into dev Sep 25, 2024
21 of 22 checks passed
@tenthe tenthe deleted the 3247-timerangeselectors-e2e-test-fails-in-nightly-cicd-runs branch September 25, 2024 10:30
dominikriemer added a commit that referenced this pull request Sep 27, 2024
* chore(deps): bump peter-evans/create-pull-request from 6 to 7 (#3215)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6...v7)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(#3247): Add waiting time and add test to smoke tests (#3248)

* fix(#3247): Add waiting time and add test to smoke tests

* fix(#3247): Fix linting

* fix(#3247): Try to remove the loop

* fix(#3247): Add timeout to open new data view

* fix(#3247): Change opc ua test and rime range test

* fix: Properly update output streams in functions (#3238)

* fix: Better handle runtime-resolved selections

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Zehnder <[email protected]>
dominikriemer added a commit that referenced this pull request Sep 30, 2024
* refactor: Rename domain properties to semantic type

* Fix cloning

* Fix serialization, remove domain property references

* Improve serializer

* Fix error

* fix: Improve handling of runtime-resolved selections (#3255)

* chore(deps): bump peter-evans/create-pull-request from 6 to 7 (#3215)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v6...v7)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(#3247): Add waiting time and add test to smoke tests (#3248)

* fix(#3247): Add waiting time and add test to smoke tests

* fix(#3247): Fix linting

* fix(#3247): Try to remove the loop

* fix(#3247): Add timeout to open new data view

* fix(#3247): Change opc ua test and rime range test

* fix: Properly update output streams in functions (#3238)

* fix: Better handle runtime-resolved selections

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Zehnder <[email protected]>

* Migrate domainProperties to semantic type for python and go

* Update model, add deprecations

* Fix checkstyle

* Remove obsolete constructor

* Cleanup constructor

* Rename DomainPropertyMatch

* rename variables

* Remove console output

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Philipp Zehnder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timeRangeSelectors` e2e test fails in nightly CI/CD runs
2 participants